Alexey Serbin has posted comments on this change. Change subject: [cmake] introduce 'pb-gen' and 'krpc-gen' targets ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7777/2/CMakeLists.txt File CMakeLists.txt: Line 637: function(KUDU_PROTOBUF_GENERATE_CPP SRCS HDRS TGTS) > FWIW, FindProtobuf.cmake is already a heavily-modified form of cmake's orig The point here is to automatically add dependencies to some top-level targets. I was not sure that would be a good style to use hard-coded targets in the cmake module file. Otherwise, it would be necessary to specify the desired target to add the TGTS for dependency as a parameter in all the sites where PROTOBUF_GENERATE_CPP is used. If updating the definition of the targets in the cmake module file, which option from the mentioned above one do you prefer? -- To view, visit http://gerrit.cloudera.org:8080/7777 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48833098553ef7d3f4fae8b88079cb354b52bea1 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
