Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/7795
to review the following change.
Change subject: server: fix crash when Shutdown is called before Init
......................................................................
server: fix crash when Shutdown is called before Init
This SIGSEGV suggests unconditional access to Messenger::Shutdown is bad.
I don't know why MiniMaster::Start failed in the test but I suspect it's due
to clock unsynchronization, because that would cause ServerBase::Init to
fail before creating the Messenger.
*** SIGSEGV (@0x18) received by PID 24219 (TID 0x7fd0b2486c40) from PID 24;
stack trace: ***
@ 0x7fd0ad48c330 (unknown) at ??:0
@ 0x7fd0ac46e24f kudu::percpu_rwlock::lock() at ??:0
@ 0x7fd0aab3ee59 kudu::rpc::Messenger::ShutdownInternal() at ??:0
@ 0x7fd0aab3f0bc kudu::rpc::Messenger::Shutdown() at ??:0
@ 0x7fd0aff36bc8 kudu::server::ServerBase::Shutdown() at ??:0
@ 0x7fd0aff33749 kudu::server::ServerBase::~ServerBase() at ??:0
@ 0x7fd0b1451a08 kudu::kserver::KuduServer::~KuduServer() at ??:0
@ 0x7fd0b144f5be kudu::master::Master::~Master() at ??:0
@ 0x7fd0b144f72a kudu::master::Master::~Master() at ??:0
@ 0x7fd0b14687c4 kudu::master::MiniMaster::Start() at ??:0
@ 0x4d10a4 kudu::master::SysCatalogTest::SetUp() at
/home/jenkins-slave/workspace/kudu-master/0/src/kudu/master/sys_catalog-test.cc:?
@ 0x7fd0b112fb3a
testing::internal::HandleExceptionsInMethodIfSupported<>() at ??:0
@ 0x7fd0b110fb27 testing::Test::Run() at ??:0
@ 0x7fd0b1111037 testing::TestInfo::Run() at ??:0
@ 0x7fd0b1111da7 testing::TestCase::Run() at ??:0
@ 0x7fd0b111d897 testing::internal::UnitTestImpl::RunAllTests() at ??:0
@ 0x7fd0b1130a1a
testing::internal::HandleExceptionsInMethodIfSupported<>() at ??:0
@ 0x7fd0b111d2e2 testing::UnitTest::Run() at ??:0
@ 0x7fd0b208f3dc RUN_ALL_TESTS() at ??:0
@ 0x7fd0b208eb97 main at ??:0
@ 0x7fd0a5733f45 __libc_start_main at ??:0
@ 0x4311a7 (unknown) at ??:?
@ 0x0 (unknown)
Change-Id: I1e36318d93cabd9d98e43951cee2075272f8f799
---
M src/kudu/kserver/kserver.cc
M src/kudu/server/server_base.cc
2 files changed, 6 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/7795/1
--
To view, visit http://gerrit.cloudera.org:8080/7795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1e36318d93cabd9d98e43951cee2075272f8f799
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
