Todd Lipcon has submitted this change and it was merged. Change subject: Revert "KUDU-2065, KUDU-2011: Release sidecars on cancellation or timeout" ......................................................................
Revert "KUDU-2065, KUDU-2011: Release sidecars on cancellation or timeout" This reverts commit 351337ee2d92361e2c87699d1c87a49774a3ab4d. This patch seemed to cause a problem in test cluster that runs YCSB stress tests. An RPC client and server got "out of sync" somehow on a connection so that the footer of one call was interpreted as the length prefix of the next call by the server. It then expected a 40MB+ RPC and just sat there consuming RPC calls for many hours assuming it was all part of one large RPC. The other end just kept timing out since it was sending calls and not getting any responses. Michael and I looked into it for a while and found one issue but still couldn't fully explain how this happened, so we'll revert for now. Change-Id: I1430cabfc54e858c1ad073574404821ae71c169f Reviewed-on: http://gerrit.cloudera.org:8080/7788 Tested-by: Todd Lipcon <[email protected]> Reviewed-by: Todd Lipcon <[email protected]> --- M docs/design-docs/rpc.md M src/kudu/rpc/blocking_ops.cc M src/kudu/rpc/connection.cc M src/kudu/rpc/connection.h M src/kudu/rpc/constants.cc M src/kudu/rpc/inbound_call.cc M src/kudu/rpc/inbound_call.h M src/kudu/rpc/outbound_call.cc M src/kudu/rpc/outbound_call.h M src/kudu/rpc/reactor.cc M src/kudu/rpc/rpc-test-base.h M src/kudu/rpc/rpc-test.cc M src/kudu/rpc/rpc_header.proto M src/kudu/rpc/rtest.proto M src/kudu/rpc/serialization.cc M src/kudu/rpc/serialization.h M src/kudu/rpc/server_negotiation.cc M src/kudu/rpc/transfer.cc M src/kudu/rpc/transfer.h 19 files changed, 157 insertions(+), 530 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/7788 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1430cabfc54e858c1ad073574404821ae71c169f Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]>
