Alexey Serbin has posted comments on this change. Change subject: log block manager: use unsigned int for next_block_id_ ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7796/2//COMMIT_MSG Commit Message: PS2, Line 18: unsinged typo, should be unsigned http://gerrit.cloudera.org:8080/#/c/7796/2/src/kudu/fs/log_block_manager.h File src/kudu/fs/log_block_manager.h: PS2, Line 411: AtomicInt maybe, to be on the safe side, use std::atomic<uint64_t> here to have well-defined behavior in case of overflow? -- To view, visit http://gerrit.cloudera.org:8080/7796 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib315b20719ef529331304df5c56c4242902524d4 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
