Adar Dembo has posted comments on this change. Change subject: log block manager: use unsigned int for next_block_id_ ......................................................................
Patch Set 2: (1 comment) The test failures are unrelated; some test machine clocks are unsynchronized for some reason. http://gerrit.cloudera.org:8080/#/c/7796/2/src/kudu/fs/log_block_manager.h File src/kudu/fs/log_block_manager.h: PS2, Line 411: AtomicInt > maybe, to be on the safe side, use std::atomic<uint64_t> here to have well- I'd prefer if we kept the scope of this patch limited, and we already use util/atomic throughout the block manager code. -- To view, visit http://gerrit.cloudera.org:8080/7796 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib315b20719ef529331304df5c56c4242902524d4 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
