Hao Hao has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7835

Change subject: KUDU-2102: fix PosixRWFile::Sync to guarantee durability when 
used concurrently
......................................................................

KUDU-2102: fix PosixRWFile::Sync to guarantee durability when
used concurrently

PosixRWFile has an AtomicBool to optimize the perfomance of Sync()
so that when two threads call Sync() at the same time, only one will
actually do the fsync(). However, the optimazation may results in one
thread returning from the call early and operating under the assumption
that the file's data has been made durable, even though it is stil in
the process of being synchronized to disk.

This patch fixs this issue simply by removing the optimization. Since
the overhead of no-op fsync() is purely syscall-related.

Change-Id: Ifaf2686233b2553de6d4a4c76fa67cc48dd340d4
---
M src/kudu/util/env_posix.cc
1 file changed, 0 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/35/7835/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7835
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifaf2686233b2553de6d4a4c76fa67cc48dd340d4
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <[email protected]>

Reply via email to