Hao Hao has posted comments on this change. Change subject: KUDU-2102: fix PosixRWFile::Sync to guarantee durability when used concurrently ......................................................................
Patch Set 1: (5 comments) It looks like IWYU is giving false alarm. Maybe we can ignore it again? http://gerrit.cloudera.org:8080/#/c/7835/1//COMMIT_MSG Commit Message: PS1, Line 12: results > result Done PS1, Line 12: optimazation > optimization Done PS1, Line 14: stil > still Done PS1, Line 17: fixs > fixes Done PS1, Line 17: Since : the overhead of no-op fsync() is purely syscall-related > This reads like a sentence fragment. Maybe you're missing the second part o Done -- To view, visit http://gerrit.cloudera.org:8080/7835 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifaf2686233b2553de6d4a4c76fa67cc48dd340d4 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
