Todd Lipcon has posted comments on this change.

Change subject: KUDU-1976. java: use ephemeral ports for MiniKDC
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7850/1/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKdc.java
File java/kudu-client/src/test/java/org/apache/kudu/client/MiniKdc.java:

Line 90:   private int kdcPort;
> Actually, I think it would be even better to get rid of this member variabl
we need the var so that if we stop and restart the kdc (eg in some kind of 
fault test) it restarts on the same port as before


Line 177:     createKrb5Conf();
> Do we need to update the kdc.conf as well, or it's not used further by anyt
nope, it's only read by the KDC itself (follownig the example of the C++ code 
here)


-- 
To view, visit http://gerrit.cloudera.org:8080/7850
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e75d89616e6dbca6e8687eeb23f807c3c7eb952
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to