Jun He has posted comments on this change. Change subject: KUDU-1811: C++ client: use larger batches when fetching scan tokens ......................................................................
Patch Set 5: (1 comment) BTW, will this be included in 1.5 release? http://gerrit.cloudera.org:8080/#/c/7748/5/src/kudu/client/meta_cache.h File src/kudu/client/meta_cache.h: Line 390: void LookupTabletsByKeyOrNext(const KuduTable* table, > I don't quite follow - from looking at the C++ implementation, it's always Sorry for the confusion. What I meant was that kMaxReturnedTableLocations is internal and is not exposed to other external classes. It seems inconsistent to only expose kFetchTabletsPerRangeLookup as a public constant. Following the current the design of the Java implementation (e.g. getTabletsLocations), we can use a similar wrapper method (LookupTabletsByKeyOrNext) for token generator. Adding a new parameter to LookupTabletByKeyOrNext can allow us to set the max returned tablets per caller. But I still think it is better to make C++ and Java clients as consistent as possible. Let me know if we want to change Java implementation. Thanks. -- To view, visit http://gerrit.cloudera.org:8080/7748 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79340dc9963944454770d82a2fbaba1b0c8a810e Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jun He <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jun He <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
