Dan Burkert has posted comments on this change. Change subject: KUDU-1811: C++ client: use larger batches when fetching scan tokens ......................................................................
Patch Set 5: (1 comment) In terms of 1.5 we can include this if it's in shape to get committed in the next ~2 days. http://gerrit.cloudera.org:8080/#/c/7748/5/src/kudu/client/meta_cache.h File src/kudu/client/meta_cache.h: Line 390: void LookupTabletsByKeyOrNext(const KuduTable* table, > Sorry for the confusion. Yah I think it would be better to expose this as an additional parameter instead of a new method. The Java APIs for table locations are a bit of a mess, they've grown haphazardly as needed instead of well designed (much of it due to me). In terms of exposing the constants publicly in the MetaCache class, I think it's fine because these aren't externally visible APIs - they are internal to the client. -- To view, visit http://gerrit.cloudera.org:8080/7748 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79340dc9963944454770d82a2fbaba1b0c8a810e Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jun He <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jun He <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
