Todd Lipcon has posted comments on this change.

Change subject: WIP: use C++ ExternalMiniCluster for Java and Python tests
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7853/2//COMMIT_MSG
Commit Message:

PS2, Line 47: WIP because, well, it should be pretty obvious. I was able to get 
through a
            : full run of "mvn verify" locally, so I have confidence that this 
can work.
            : But I'd like to solicit feedback on the general approach before 
spending
            : more time applying spit and polish.
> I went back and forth on this.
I'm just worried that, as we add features, the parsing is going to get more 
complicated than just noun/verb. eg what if I want to run a kerberized 
minicluster, but with a custom realm, or with two KDCs set up for cross-realm 
trust in the future, etc?

Maybe we could have the most simple "start a non-kerberized cluster with 3 
servers" be done with interactive use, since a developer might want to use this 
for local playing around, but then make anything more complicated (eg custom 
flags, more exotic configs) require JSON?


-- 
To view, visit http://gerrit.cloudera.org:8080/7853
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e693921ef780dc4a06e536c6b7408f7f0b252f6
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to