Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/7951
to review the following change.
Change subject: cow_object: lazily copy dirty state
......................................................................
cow_object: lazily copy dirty state
This addresses a long-standing TODO that ought to improve performance of
tablet reports in the steady-state: within the COWed objects, defer the
creation of the "dirty" copy until it's actually needed (i.e. until the
first call to mutable_data()).
The deferral introduces new branches in dirty() and mutable_dirty(), but
given the paucity of those calls for any given lock instance, I think this
is a reasonable trade-off.
Change-Id: Ic00c573717e7cb8df1942ba0760726fd0961e1d6
---
M src/kudu/master/catalog_manager.cc
M src/kudu/util/cow_object.h
2 files changed, 19 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/7951/1
--
To view, visit http://gerrit.cloudera.org:8080/7951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic00c573717e7cb8df1942ba0760726fd0961e1d6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
