Adar Dembo has posted comments on this change. Change subject: cow_object: lazily copy dirty state ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/7951/1/src/kudu/util/cow_object.h File src/kudu/util/cow_object.h: Line 73: CHECK(dirty_state_); > maybe not worth removing, but this check is now redundant. Done PS1, Line 97: DCHECK_NOTNULL > likewise Done PS1, Line 104: DCHECK_NOTNULL > likewise Done -- To view, visit http://gerrit.cloudera.org:8080/7951 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic00c573717e7cb8df1942ba0760726fd0961e1d6 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
