Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric ......................................................................
Patch Set 13: (4 comments) http://gerrit.cloudera.org:8080/#/c/6968/13/src/kudu/consensus/consensus_meta.cc File src/kudu/consensus/consensus_meta.cc: Line 305: flush_count_for_tests_(0) { > consider initializing on_disk_size_ with 0 as well. Done http://gerrit.cloudera.org:8080/#/c/6968/13/src/kudu/consensus/consensus_meta.h File src/kudu/consensus/consensus_meta.h: PS13, Line 244: int64 > What is the reason to have this int64 instead of uint64_t which corresponds It's just for consistency with the other on disk size metrics. They were a mix of things but Mike requested they be int64_t according to GSG guidelines for signed vs. unsigned (speaking of which this should be an int64_t). Comment added. http://gerrit.cloudera.org:8080/#/c/6968/10/src/kudu/tablet/diskrowset.cc File src/kudu/tablet/diskrowset.cc: Line 690: Status DiskRowSet::CountRows(rowid_t *count) const { > On #1, I'm pretty certain that we need to acquire the lock to get a ref to Yes, I think we can take a ref under the lock and then call OnDiskSize() without the lock. delta_tracker_ doesn't require the lock at all. I've rewritten a couple of the methods to reflect this. http://gerrit.cloudera.org:8080/#/c/6968/10/src/kudu/tablet/tablet_replica.cc File src/kudu/tablet/tablet_replica.cc: PS10, Line 645: : Status TabletRepli > > TabletReplica::Shutdown() resets consensus_ with lock_ held. Old. Done. -- To view, visit http://gerrit.cloudera.org:8080/6968 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia83f8aae0a544abbd19f5a34520b4828b89b6315 Gerrit-PatchSet: 13 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-HasComments: Yes
