Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric ......................................................................
Patch Set 17: (3 comments) http://gerrit.cloudera.org:8080/#/c/6968/16/src/kudu/consensus/log-test.cc File src/kudu/consensus/log-test.cc: PS16, Line 1166: ASSERT_EQ(3, anchors.size()); > nit: the expected value comes first Done http://gerrit.cloudera.org:8080/#/c/6968/15/src/kudu/consensus/log.cc File src/kudu/consensus/log.cc: PS15, Line 910: f the log is closed, the > What happens with the log when it closes? Does it effective size go zero i I believe the latter is the case-- the log is closed when the tablet is shutdown, which I believe happens only when the tablet is deleted or tombstoned. I added a comment explaining this. http://gerrit.cloudera.org:8080/#/c/6968/16/src/kudu/tablet/tablet_replica.h File src/kudu/tablet/tablet_replica.h: PS16, Line 24: #include <mutex> > nit: prefer <cstddef> for C++11 (I need to update IWYU stuff to give proper Done -- To view, visit http://gerrit.cloudera.org:8080/6968 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia83f8aae0a544abbd19f5a34520b4828b89b6315 Gerrit-PatchSet: 17 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-HasComments: Yes