Adar Dembo has posted comments on this change. Change subject: Add tablet state summary metrics ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7980/2/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: Line 1227: if (last_walked_ + period > MonoTime::Now()) { Nit: maybe refactor: if (last_walked_ + period < MonoTime::Now()) { // Our cached counts are too old, regenerate them. <walk map and update counts> last_walked_ = Now(); } return CountForState(st); http://gerrit.cloudera.org:8080/#/c/7980/2/src/kudu/tserver/ts_tablet_manager.h File src/kudu/tserver/ts_tablet_manager.h: Line 329: // Update the TabletStateSummary for this tablet manager. Update this. -- To view, visit http://gerrit.cloudera.org:8080/7980 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9fda2061d341586f0aa343787af59984a627080a Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
