Will Berkeley has posted comments on this change. Change subject: Add tablet state summary metrics ......................................................................
Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/7980/1/src/kudu/integration-tests/tablet_copy-itest.cc File src/kudu/integration-tests/tablet_copy-itest.cc: PS1, Line 1545: ASSERT_EVENTUALLY([&] { : ASSERT_EQ(1, CountRunningTablets(cluster_->tablet_server(follower_index)) > Can you use ASSERT_EVENTUALLY rather than sleeping? Done http://gerrit.cloudera.org:8080/#/c/7980/3/src/kudu/integration-tests/tablet_copy-itest.cc File src/kudu/integration-tests/tablet_copy-itest.cc: Line 1555: SleepFor(MonoDelta::FromMilliseconds(15)); > Shouldn't need an explicit sleep anymore; let ASSERT_EVENTUALLY() take care :( http://gerrit.cloudera.org:8080/#/c/7980/2/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: Line 1227: if (last_walked_ + period < MonoTime::Now()) { > Nit: maybe refactor: Done http://gerrit.cloudera.org:8080/#/c/7980/3/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: PS3, Line 1230: auto & > Nit: 'const auto&' is actually more GSG-compliant, since the '&' is part of I plead innocent. My IDE moves *'s and &'s when I'm not looking. I did go fix the setting for it, so shouldn't happen anymore. http://gerrit.cloudera.org:8080/#/c/7980/2/src/kudu/tserver/ts_tablet_manager.h File src/kudu/tserver/ts_tablet_manager.h: Line 329: // Update the TabletStateSummary for this tablet manager and return the > Update this. Done -- To view, visit http://gerrit.cloudera.org:8080/7980 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9fda2061d341586f0aa343787af59984a627080a Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
