Adar Dembo has posted comments on this change. Change subject: KUDU-2044 Tombstoned tablets show up in /metrics ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7981/1//COMMIT_MSG Commit Message: PS1, Line 12: If a new copy of the tablet is placed on the server, the new : tablet's metric entity will replace the old one, if the old one's : hasn't been deregistered yet (steps toward deregistration occur only : when the entity publishes metrics e.g. on a call to /metrics). > The old entity is deregistered. This situation is what's tested in tablet_c I'm still finding this sentence confusing. The old entity is replaced if it _was not_ deregistered? And if it was already deregistered, then it's deregistered now, and replaced? Could you maybe reword this to clarify exactly what's going on? http://gerrit.cloudera.org:8080/#/c/7981/2/src/kudu/tserver/tablet_server-test.cc File src/kudu/tserver/tablet_server-test.cc: PS2, Line 2582: // The first two calls to /jsonmetricz should show tablet metrics: : // 1. The first call causes the registry to discover the tablet's metric entity : // has been unpublished and marks it for retirement after the expiration period. : // 2. The second call causes the entity to retire all its metrics, since we've : // passed the retirement period. Then, the registry de-registers the entity. : // Therefore, a third call will not see tablet metrics. Nit: since you have a 2-item list already set up, I think formatting the third call as the third item would be more readable. Something like: // We make three calls to /jsonmetrics. // 1. Return the metric, but mark it for retirement. // 2. Return it, but also retire it. // 3. Don't return it because it's been retired. -- To view, visit http://gerrit.cloudera.org:8080/7981 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21b52262203410ded1e514502b59a79be12f8fb3 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
