Will Berkeley has posted comments on this change. Change subject: KUDU-2044 Tombstoned tablets show up in /metrics ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/7981/1//COMMIT_MSG Commit Message: PS1, Line 12: If a new copy of the tablet is placed on the server, the new : tablet's metric entity will replace the old one, if the old one's : hasn't been deregistered yet (steps toward deregistration occur only : when the entity publishes metrics e.g. on a call to /metrics). > I'm still finding this sentence confusing. The old entity is replaced if it Will reword. I think the confusion here is that deregister != unpublish. Unpublishing just marks the entity for eventual deregistration. Deregistration is simply the metric registry erasing the entity from its map of entities. Metrics ultimately stop showing up only when the entity is deregistered, not merely when it is unpublished. http://gerrit.cloudera.org:8080/#/c/7981/2/src/kudu/integration-tests/tablet_copy-itest.cc File src/kudu/integration-tests/tablet_copy-itest.cc: Line 111: using std::vector; > warning: redundant 'METRIC_ENTITY_server' declaration [readability-redundan Done http://gerrit.cloudera.org:8080/#/c/7981/2/src/kudu/tserver/tablet_server-test.cc File src/kudu/tserver/tablet_server-test.cc: PS2, Line 2582: // The next two calls to /jsonmetricz should show tablet metrics: : // 1. The first call causes the registry to discover the tablet's metric entity : // has been de-published and marks it for retirement after the expiration period. : // 2. The second call causes the entity to retire all its metrics, since we've : // passed the retirement period. Then, the registry de-registers the entity. : EasyCurl c; > Nit: since you have a 2-item list already set up, I think formatting the th Done -- To view, visit http://gerrit.cloudera.org:8080/7981 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21b52262203410ded1e514502b59a79be12f8fb3 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-HasComments: Yes
