Adar Dembo has posted comments on this change. Change subject: KUDU-2123. Auto-vivify cmeta on tombstoned replicas if doesn't exist at startup ......................................................................
Patch Set 2: (4 comments) Was just passing through because I was interested. http://gerrit.cloudera.org:8080/#/c/7988/2//COMMIT_MSG Commit Message: PS2, Line 7: replicas Nit: replica ("doesn't" implies singular) PS2, Line 11: Not having a cmeta : file results in those tombstoned replicas being unable to vote in Raft : leader elections Given the conditions you spelled out in the previous sentence, it seems like not having a cmeta would be quite rare. Why is it important for these replicas to be able to vote? PS2, Line 27: ConsensConsensusMetadataManager ConsensusMetadataManager PS2, Line 33: thethe the -- To view, visit http://gerrit.cloudera.org:8080/7988 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ff6255b1fcbb12417b82853bcde9b239291492b Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
