Alexey Serbin has posted comments on this change. Change subject: KUDU-2123. Auto-vivify cmeta on tombstoned replicas if doesn't exist at startup ......................................................................
Patch Set 6: (7 comments) I have the following question: why do we need to introduce that additional state into ConsensusMetadata object? Why not to leave the OVERWRITE/NO_OVERWRITE parameter for its Flush() method? http://gerrit.cloudera.org:8080/#/c/7988/4/src/kudu/consensus/consensus_meta-test.cc File src/kudu/consensus/consensus_meta-test.cc: PS4, Line 18: #include <stdint.h> nit: consider returning back to <cstdint>. Sorry, I missed this in the first revision. http://gerrit.cloudera.org:8080/#/c/7988/6/src/kudu/consensus/consensus_meta.cc File src/kudu/consensus/consensus_meta.cc: PS6, Line 334: /*overwrite_first_flush=*/ false Why not just to pass the NO_OVERWRITE flag to the Flush() method as it was before? I'm not a big fan of introducing some more object state in here. http://gerrit.cloudera.org:8080/#/c/7988/6/src/kudu/consensus/consensus_meta_manager.cc File src/kudu/consensus/consensus_meta_manager.cc: Line 96: return Create(tablet_id, config, initial_term, create_mode); Does it make sense to pass the cmeta_out here as well? http://gerrit.cloudera.org:8080/#/c/7988/6/src/kudu/tablet/tablet_replica-test.cc File src/kudu/tablet/tablet_replica-test.cc: PS6, Line 86: using consensus::ConsensusMetadataCreateMode; nit: is it needed? http://gerrit.cloudera.org:8080/#/c/7988/6/src/kudu/tserver/tablet_copy_source_session-test.cc File src/kudu/tserver/tablet_copy_source_session-test.cc: PS6, Line 91: using consensus::ConsensusMetadataCreateMode; nit: is it needed? http://gerrit.cloudera.org:8080/#/c/7988/6/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: PS6, Line 127: using consensus::ConsensusMetadataCreateMode; nit: is it needed? PS6, Line 1093: scoped_refptr<ConsensusMetadata> cmeta; nit: it seems the 'cmeta' is not used in this scope; drop it, maybe? -- To view, visit http://gerrit.cloudera.org:8080/7988 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ff6255b1fcbb12417b82853bcde9b239291492b Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
