Hello Dan Burkert, Jean-Daniel Cryans, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/8027
to review the following change.
Change subject: KUDU-1807 (part 2): stop calling IsCreateInProgress in
GetTableSchema
......................................................................
KUDU-1807 (part 2): stop calling IsCreateInProgress in GetTableSchema
At first I tried to optimize IsCreateInProgress by caching some additional
in-memory state, but ran into a thicket of locking issues. So here's an
alternative approach: deprecate GetTableSchemaResponsePB's create_table_done
field and always set it to false.
AFAICT, the C++ client never referenced this field. The Java client does; it
uses it to decide if a table is fully created during table open. However, if
create_table_done is false, it waits further via a IsCreateTableDone RPC
loop. This means we can safely set create_table_done to false without
breaking compatibility with old Java clients; they'll compensate by issuing
an additional IsCreateTableDone RPC when opening a table.
Change-Id: Ia33bbb2abaabb97db1613d442a7d065710048cc2
---
M src/kudu/integration-tests/registration-test.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master.proto
3 files changed, 3 insertions(+), 16 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/8027/1
--
To view, visit http://gerrit.cloudera.org:8080/8027
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia33bbb2abaabb97db1613d442a7d065710048cc2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
