Dan Burkert has posted comments on this change. Change subject: KUDU-1807 (part 2): stop calling IsCreateInProgress in GetTableSchema ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8027/1//COMMIT_MSG Commit Message: Line 18: breaking compatibility with old Java clients; they'll compensate by issuing Shouldn't this be part 1? Making this part 1 would at least give us some amount of confidence that the existing Java client can interoperate with this change. http://gerrit.cloudera.org:8080/#/c/8027/1/src/kudu/master/master.proto File src/kudu/master/master.proto: Line 585: optional bool DEPRECATED_create_table_done = 6; Instead of renaming, change to: optional bool create_table_done = 6 [deprecated=true]; Also, consider adding a part 3 which removes the field and adds 6 as a reserved tag (https://developers.google.com/protocol-buffers/docs/proto#reserved). -- To view, visit http://gerrit.cloudera.org:8080/8027 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia33bbb2abaabb97db1613d442a7d065710048cc2 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
