Adar Dembo has posted comments on this change. Change subject: [iwyu] update std::move ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8088/1/build-support/iwyu/mappings/libstdcpp.imp File build-support/iwyu/mappings/libstdcpp.imp: Line 31: { symbol: ["std::move", private, "<algorithm>", public ] }, > Because of http://en.cppreference.com/w/cpp/algorithm/move Do we actually use that variant of std::move though? I was hoping the 'symbol' notation would be rich enough to choose between the variants, but it doesn't appear to be [1]. There's a bug to support regular expression matching [2], but it looks like it's about to be closed as WONTFIX. 1. https://github.com/include-what-you-use/include-what-you-use/blob/master/docs/IWYUMappings.md#symbol-mappings 2. https://github.com/include-what-you-use/include-what-you-use/issues/233 http://gerrit.cloudera.org:8080/#/c/8088/1/src/kudu/consensus/raft_consensus_quorum-test.cc File src/kudu/consensus/raft_consensus_quorum-test.cc: Line 83 > It's two-fold: I see. Feel free to keep these changes in this patch, though if you've already gone through the trouble to move them out, that's fine too. -- To view, visit http://gerrit.cloudera.org:8080/8088 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5972f9a43f4c1db4a0dff5f983f7dba90c8db31 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
