Adar Dembo has posted comments on this change. Change subject: [iwyu] update std::move ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/8088/4/src/kudu/rpc/rpc_sidecar.h File src/kudu/rpc/rpc_sidecar.h: Line 23: #include <google/protobuf/stubs/port.h> > That's for ::google::protobuf::uint32 as it is in the signature of the Pars I don't think that's possible without either casting or copying because the input to ParseSidcars is a PB from the wire. Let's just leave it as-is. -- To view, visit http://gerrit.cloudera.org:8080/8088 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5972f9a43f4c1db4a0dff5f983f7dba90c8db31 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
