Adar Dembo has posted comments on this change. Change subject: Link to troubleshooting docs for two common problems ......................................................................
Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/8093/2/docs/troubleshooting.adoc File docs/troubleshooting.adoc: Line 311: - Increase the rate at which Kudu can flush writes from memory to disk by increasing the number of This ought to also encourage people to commit more disks to Kudu, which increases aggregate flush bandwidth. BTW, we have a better "formula" for configuring the number of MM threads vis a vis the number of disks. From the 1.4.0 upgrade notes: "Generally, the recommended ratio of MM threads to data directories is 1:3; operators of clusters above that ratio should be mindful of this when upgrading." PS2, Line 323: F0425 15:11:54.572299 2733 tablet_server_main.cc:64] Do you think it would be more readable if the glog prefix were omitted? http://gerrit.cloudera.org:8080/#/c/8093/2/src/kudu/util/logging_util.h File src/kudu/util/logging_util.h: Looks like these functions are all about generating URLs to the Kudu website. So maybe "website_util" would be a more appropriate module name? Line 33: std::string KuduTroubleshootingUrl(); What do you think of renaming this to KuduDocsTroubleshootingUrl? I think it's nice if the function names mirror the "nesting" that happens on the website (where troubleshooting is a component of docs). http://gerrit.cloudera.org:8080/#/c/8093/2/src/kudu/util/version_info.h File src/kudu/util/version_info.h: Line 32: static std::string GetVersionString(); It would be nice to continue emphasizing the similarities with GetShortVersionInfo and GetAllVersionInfo, so maybe rename this to GetShortestVersionInfo? Alternatively: - GetShortVersionInfo (this function) - GetVersionInfo (currently GetShortVersionInfo) - GetAllVersionInfo (remains unchanged) -- To view, visit http://gerrit.cloudera.org:8080/8093 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida7e1495e4ba68f9e9b4d424650d84c0019c9b0f Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
