Will Berkeley has posted comments on this change. Change subject: Link to troubleshooting docs for two common problems ......................................................................
Patch Set 2: (8 comments) http://gerrit.cloudera.org:8080/#/c/8093/2/docs/troubleshooting.adoc File docs/troubleshooting.adoc: PS2, Line 299: producing backpressure, > s/start producing backpressure/trigger backpressure handling mechanisms? or Removed in favor of just "before it will start rejecting some write operations." Line 311: - Increase the rate at which Kudu can flush writes from memory to disk by increasing the number of > This ought to also encourage people to commit more disks to Kudu, which inc Good point. Thank you for pointing out that release note. I wasn't aware of it and will include the advice here. PS2, Line 311: - Increase the rate at which Kudu can flush writes from memory to disk by increasing the number of : maintenance manager threads `--maintenance_manager_num_threads`. For spinning disks, the number of : threads should not exceed the number of devices. > maybe lets put this one first? Why would you like that one first? In my experience, the most common problem for newer users is actually that they don't realize they can just increase the limit, or they don't realize the memory limit is set very low. A good example of this is that Cloudera Manager's default memory limit for Kudu is set very conservatively, so it's almost guaranteed a user with an enterprise-class server needs to drastically increase the CM-configured default memory limit to get expected performance. PS2, Line 323: F0425 15:11:54.572299 2733 tablet_server_main.cc:64] > Do you think it would be more readable if the glog prefix were omitted? Done http://gerrit.cloudera.org:8080/#/c/8093/2/src/kudu/util/logging_util.h File src/kudu/util/logging_util.h: > Looks like these functions are all about generating URLs to the Kudu websit Done Line 33: std::string KuduTroubleshootingUrl(); > What do you think of renaming this to KuduDocsTroubleshootingUrl? I think i Done PS2, Line 40: // Favor this over the unversioned version. > why have the unversioned version then? Originally just as a bonus, but I can't really think of when we would want to link to the latest docs from a release, so I took them out and simplified the naming as a result. http://gerrit.cloudera.org:8080/#/c/8093/2/src/kudu/util/version_info.h File src/kudu/util/version_info.h: Line 32: static std::string GetVersionString(); > It would be nice to continue emphasizing the similarities with GetShortVers Done -- To view, visit http://gerrit.cloudera.org:8080/8093 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida7e1495e4ba68f9e9b4d424650d84c0019c9b0f Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
