Todd Lipcon has posted comments on this change. Change subject: parse_metrics_log: merge metrics across entities of same type ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/8062/1/src/kudu/scripts/parse_metrics_log.py File src/kudu/scripts/parse_metrics_log.py: PS1, Line 99: if k == 'name': : continue : if k == 'values' or k == 'counts' or k == 'min' or k == 'max' or k == 'mean': : continue > Nit: combine? Done Line 103: else: > Nit: no need for the else. Done Line 161: cur.get('counts', [])) > Nit: indentation here. Done Line 237: if prev_data and ts < prev_data['ts'] + 30: > Worth a comment explaining this check. moved the magic value 30 to a constant. Also added an extra check here to make sure that timestamps are ascending (an assumption of the code but not enforced prior) -- To view, visit http://gerrit.cloudera.org:8080/8062 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I442cddd4c5352dcfae30fa23888082d916069d5f Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
