Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8116 )
Change subject: periodic: prevent runaway callback loops ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8116/1/src/kudu/rpc/reactor.cc File src/kudu/rpc/reactor.cc: http://gerrit.cloudera.org:8080/#/c/8116/1/src/kudu/rpc/reactor.cc@101 PS1, Line 101: METRIC_DEFINE_counter(server, reactor_delayed_tasks_completed, is this actually useful in a production context or just for tests? if the latter, I think a simple variable is probably better (and can just reach in through friend classes or somesuch to get access to it). I hesitate to pollute public metrics namespaces with implementation details like this. -- To view, visit http://gerrit.cloudera.org:8080/8116 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37bfd547db2a6c58d15d228979c88b9b871f72c5 Gerrit-Change-Number: 8116 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 21 Sep 2017 04:50:20 +0000 Gerrit-HasComments: Yes
