Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/7656 )
Change subject: KUDU-2055 [part 1]: Add fs::BlockDeletionTransaction API ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/7656/9/src/kudu/fs/block_manager.h File src/kudu/fs/block_manager.h: http://gerrit.cloudera.org:8080/#/c/7656/9/src/kudu/fs/block_manager.h@325 PS9, Line 325: Status CommitDeletedBlocks(std::vector<BlockId>* deleted) { > OK, could you document this behavior. Right now it says 'The 'deleted' out Sure, will update the comment. -- To view, visit http://gerrit.cloudera.org:8080/7656 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iecb252b3a5665d5471bb82301d0c8012a68de959 Gerrit-Change-Number: 7656 Gerrit-PatchSet: 10 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Fri, 22 Sep 2017 21:32:01 +0000 Gerrit-HasComments: Yes
