Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/7656 )
Change subject: KUDU-2055 [part 1]: Add fs::BlockDeletionTransaction API ...................................................................... KUDU-2055 [part 1]: Add fs::BlockDeletionTransaction API Similar to 'BlockCreationTransaction', this patch adds a new layer of abstraction at Block Manager to coalesce blocks deletions in a logical operation, e.g. compaction. By coalescing blocks deletions, the number of holes punched in LBM will be reduced from one per block to one per log block container in the best case (that the individual holes in one container are all contiguous). This should overall optimize the performance of operation that involves batch deletions, such as tablet deletion and hole repunching. This patch is the first part of a series. It only adds the new abstraction 'BlockDeletionTransaction', and doesn't yet change any deletion semantics or improve performance. Change-Id: Iecb252b3a5665d5471bb82301d0c8012a68de959 Reviewed-on: http://gerrit.cloudera.org:8080/7656 Tested-by: Kudu Jenkins Reviewed-by: Dan Burkert <[email protected]> --- M src/kudu/cfile/bloomfile.cc M src/kudu/cfile/cfile-test.cc M src/kudu/cfile/cfile_writer.cc M src/kudu/cfile/cfile_writer.h M src/kudu/fs/block_manager-test.cc M src/kudu/fs/block_manager.h M src/kudu/fs/log_block_manager-test.cc M src/kudu/tablet/deltafile.cc M src/kudu/tablet/diskrowset.cc M src/kudu/tablet/multi_column_writer.cc M src/kudu/tserver/tablet_copy_client.cc 11 files changed, 109 insertions(+), 20 deletions(-) Approvals: Kudu Jenkins: Verified Dan Burkert: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/7656 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Iecb252b3a5665d5471bb82301d0c8012a68de959 Gerrit-Change-Number: 7656 Gerrit-PatchSet: 13 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot
