Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8130 )
Change subject: periodic: add one-shot timers ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8130/1/src/kudu/rpc/periodic.cc File src/kudu/rpc/periodic.cc: http://gerrit.cloudera.org:8080/#/c/8130/1/src/kudu/rpc/periodic.cc@61 PS1, Line 61: options_(std::move(options)), > warning: std::move of the variable 'options' of the trivially-copyable type I'm going to ignore these warnings, because they'll be wrong if/when PeriodicTimer::Options grows a member that is a candidate for moving (like std::string), and we won't know to update all the pass-by-value sites. -- To view, visit http://gerrit.cloudera.org:8080/8130 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia4d9376172d66c92958071d5abbac63d751e41f3 Gerrit-Change-Number: 8130 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Sat, 23 Sep 2017 00:43:11 +0000 Gerrit-HasComments: Yes
