Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8130 )
Change subject: periodic: add one-shot timers ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8130/2/src/kudu/rpc/periodic.h File src/kudu/rpc/periodic.h: http://gerrit.cloudera.org:8080/#/c/8130/2/src/kudu/rpc/periodic.h@81 PS2, Line 81: // The timer will automatically stop after running the user's task. can you clarify a bit what the behavior of "Snooze" and "Stop" are in the case of a one-shot? i.e does Snooze have the effect of continuing to postpone the firing of the one-shot, and Stop has the effect of canceling it? (assuming that it hasn't fired yet, of course) -- To view, visit http://gerrit.cloudera.org:8080/8130 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia4d9376172d66c92958071d5abbac63d751e41f3 Gerrit-Change-Number: 8130 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Fri, 29 Sep 2017 18:56:22 +0000 Gerrit-HasComments: Yes
