Hello Todd Lipcon,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/8134

to review the following change.


Change subject: WIP: consensus: disarm failure detector around elections
......................................................................

WIP: consensus: disarm failure detector around elections

This is a more complete fix for KUDU-2149 which disarms the failure detector
completely around a leader election.

There are several changes to make this happen:
1. The FD is changed to use a one-shot timer, which automatically disarms
   upon firing.
2. Because all elections are guaranteed to reach DoElectionCallback, that's
   where we rearm the FD.
3. We provide a special case for pre-elections where FD rearming is deferred
   until after the subsequent real election finishes.

WIP because it's still pretty brittle; maybe there's a more robust approach?

Change-Id: Idcd311cee028c48e908f290d60c474e8a4557d97
---
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
2 files changed, 78 insertions(+), 69 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/34/8134/1
--
To view, visit http://gerrit.cloudera.org:8080/8134
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idcd311cee028c48e908f290d60c474e8a4557d97
Gerrit-Change-Number: 8134
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>

Reply via email to