Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8134 )
Change subject: WIP: consensus: disarm failure detector around elections ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/8134/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8134/1//COMMIT_MSG@20 PS1, Line 20: WIP because it's still pretty brittle; maybe there's a more robust approach? maybe there are some DCHECKs we can add to ensure that whenever an election callback fires t hat the FD is not armed? that at least protects a bug in one d irection http://gerrit.cloudera.org:8080/#/c/8134/1/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: http://gerrit.cloudera.org:8080/#/c/8134/1/src/kudu/consensus/raft_consensus.cc@543 PS1, Line 543: Is it possible for this to fail for any other (transient) reason, eg failure to create a new thread? Maybe we could have a CHECK that ensures that if it failed to submit that the state is stopped, or somesuch? or inspect the actual type of error status http://gerrit.cloudera.org:8080/#/c/8134/1/src/kudu/consensus/raft_consensus.cc@2189 PS1, Line 2189: // that RaftConsensus has stopped and we no longer need failure detection. same http://gerrit.cloudera.org:8080/#/c/8134/1/src/kudu/consensus/raft_consensus.cc@2299 PS1, Line 2299: // TODO(adar): is this still possible now that the failure detector isn't : // armed during elections? yea it doesn't seem possible anymore since step '2' says t hat the timer expires while an election is pending. But what about the case of an externally-triggered election? -- To view, visit http://gerrit.cloudera.org:8080/8134 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idcd311cee028c48e908f290d60c474e8a4557d97 Gerrit-Change-Number: 8134 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 25 Oct 2017 19:30:24 +0000 Gerrit-HasComments: Yes
