Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8141 )
Change subject: [webui] Allow custom response codes and headers ...................................................................... Patch Set 1: (20 comments) http://gerrit.cloudera.org:8080/#/c/8141/1/src/kudu/master/master-path-handlers.cc File src/kudu/master/master-path-handlers.cc: http://gerrit.cloudera.org:8080/#/c/8141/1/src/kudu/master/master-path-handlers.cc@85 PS1, Line 85: void MasterPathHandlers::HandleTabletServers(const Webserver::WebRequest& req, > warning: parameter 'req' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/8141/1/src/kudu/master/master-path-handlers.cc@386 PS1, Line 386: void MasterPathHandlers::HandleMasters(const Webserver::WebRequest& req, > warning: parameter 'req' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/8141/1/src/kudu/master/master-path-handlers.cc@528 PS1, Line 528: void MasterPathHandlers::HandleDumpEntities(const Webserver::WebRequest& req, > warning: parameter 'req' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/8141/1/src/kudu/server/pprof-path-handlers.cc File src/kudu/server/pprof-path-handlers.cc: http://gerrit.cloudera.org:8080/#/c/8141/1/src/kudu/server/pprof-path-handlers.cc@76 PS1, Line 76: static void PprofCmdLineHandler(const Webserver::WebRequest& req, > warning: parameter 'req' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/8141/1/src/kudu/server/pprof-path-handlers.cc@87 PS1, Line 87: static void PprofHeapHandler(const Webserver::WebRequest& req, > warning: parameter 'req' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/8141/1/src/kudu/server/pprof-path-handlers.cc@88 PS1, Line 88: Webserver::PrerenderedWebResponse* resp) { > warning: parameter 'resp' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/8141/1/src/kudu/server/pprof-path-handlers.cc@90 PS1, Line 90: (*output) << "Heap profiling is not available without tcmalloc."; > error: use of undeclared identifier 'output' [clang-diagnostic-error] Done http://gerrit.cloudera.org:8080/#/c/8141/1/src/kudu/server/pprof-path-handlers.cc@117 PS1, Line 117: static void PprofCpuProfileHandler(const Webserver::WebRequest& req, > warning: parameter 'req' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/8141/1/src/kudu/server/pprof-path-handlers.cc@118 PS1, Line 118: Webserver::PrerenderedWebResponse* resp) { > warning: parameter 'resp' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/8141/1/src/kudu/server/pprof-path-handlers.cc@120 PS1, Line 120: (*output) << "CPU profiling is not available without tcmalloc."; > error: use of undeclared identifier 'output' [clang-diagnostic-error] Done http://gerrit.cloudera.org:8080/#/c/8141/1/src/kudu/server/pprof-path-handlers.cc@145 PS1, Line 145: static void PprofGrowthHandler(const Webserver::WebRequest& req, > warning: parameter 'req' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/8141/1/src/kudu/server/pprof-path-handlers.cc@146 PS1, Line 146: Webserver::PrerenderedWebResponse* resp) { > warning: parameter 'resp' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/8141/1/src/kudu/server/pprof-path-handlers.cc@148 PS1, Line 148: (*output) << "Growth profiling is not available without tcmalloc."; > error: use of undeclared identifier 'output' [clang-diagnostic-error] Done http://gerrit.cloudera.org:8080/#/c/8141/1/src/kudu/server/webserver.cc File src/kudu/server/webserver.cc: http://gerrit.cloudera.org:8080/#/c/8141/1/src/kudu/server/webserver.cc@383 PS1, Line 383: } else { > warning: do not use 'else' after 'return' [readability-else-after-return] Done http://gerrit.cloudera.org:8080/#/c/8141/1/src/kudu/server/webserver.cc@420 PS1, Line 420: // TODO: for this and other HTTP requests, we should log the > warning: missing username/bug in TODO [google-readability-todo] Done http://gerrit.cloudera.org:8080/#/c/8141/1/src/kudu/tserver/tserver-path-handlers.cc File src/kudu/tserver/tserver-path-handlers.cc: http://gerrit.cloudera.org:8080/#/c/8141/1/src/kudu/tserver/tserver-path-handlers.cc@216 PS1, Line 216: void TabletServerPathHandlers::HandleTabletsPage(const Webserver::WebRequest& req, > warning: parameter 'req' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/8141/1/src/kudu/tserver/tserver-path-handlers.cc@378 PS1, Line 378: bool GetTabletReplica(TabletServer* tserver, const Webserver::WebRequest& req, > warning: parameter 'req' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/8141/1/src/kudu/tserver/tserver-path-handlers.cc@509 PS1, Line 509: void TabletServerPathHandlers::HandleScansPage(const Webserver::WebRequest& req, > warning: parameter 'req' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/8141/1/src/kudu/tserver/tserver-path-handlers.cc@610 PS1, Line 610: void TabletServerPathHandlers::HandleDashboardsPage(const Webserver::WebRequest& req, > warning: parameter 'req' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/8141/1/src/kudu/util/thread.cc File src/kudu/util/thread.cc: http://gerrit.cloudera.org:8080/#/c/8141/1/src/kudu/util/thread.cc@224 PS1, Line 224: void ThreadPathHandler(const WebCallbackRegistry::WebRequest& args, > warning: function 'kudu::ThreadMgr::ThreadPathHandler' has a definition wit Done -- To view, visit http://gerrit.cloudera.org:8080/8141 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ff890785eeb2df3eed9e7c54d0daf760c8b3924 Gerrit-Change-Number: 8141 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Tue, 26 Sep 2017 22:40:50 +0000 Gerrit-HasComments: Yes
