Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8141 )
Change subject: [webui] Allow custom response codes and headers ...................................................................... Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/8141/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8141/4//COMMIT_MSG@17 PS4, Line 17: The ability to add headers isn't currently used, but it's nice to have. Do you expect these to be used in the near future? http://gerrit.cloudera.org:8080/#/c/8141/4/src/kudu/master/master-path-handlers.cc File src/kudu/master/master-path-handlers.cc: http://gerrit.cloudera.org:8080/#/c/8141/4/src/kudu/master/master-path-handlers.cc@243 PS4, Line 243: will nit: s/will/would (to avoid confusion around what is actually implemented) http://gerrit.cloudera.org:8080/#/c/8141/4/src/kudu/master/master-path-handlers.cc@242 PS4, Line 242: We could respond with 307 Temporary Redirect and automatically redirect with : // a Location header, but this will redirect without warning and users are liable : // to becomes confused about which master's web ui they are looking at. Is this a TODO or just a comment? If it's just a comment, maybe append something like "...Instead, we simply point users to the current leader." http://gerrit.cloudera.org:8080/#/c/8141/4/src/kudu/server/pprof-path-handlers.cc File src/kudu/server/pprof-path-handlers.cc: http://gerrit.cloudera.org:8080/#/c/8141/4/src/kudu/server/pprof-path-handlers.cc@90 PS4, Line 90: *resp->output In functions that refer to resp->output a few times, maybe pull out the ostringstream*? http://gerrit.cloudera.org:8080/#/c/8141/4/src/kudu/util/web_callback_registry.h File src/kudu/util/web_callback_registry.h: http://gerrit.cloudera.org:8080/#/c/8141/4/src/kudu/util/web_callback_registry.h@70 PS4, Line 70: headers nit: response_headers -- To view, visit http://gerrit.cloudera.org:8080/8141 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ff890785eeb2df3eed9e7c54d0daf760c8b3924 Gerrit-Change-Number: 8141 Gerrit-PatchSet: 4 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 29 Sep 2017 18:36:41 +0000 Gerrit-HasComments: Yes
