Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8161 )
Change subject: [catalog manager] introduce replica selector ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8161/3/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/8161/3/src/kudu/master/master.proto@378 PS3, Line 378: ReplicaSelector Bike-shedding, but "ReplicaSelector" (especially when seen in C++) suggests a stateful class that uses some sort of heuristic or algorithm to make a selection. The reality is that it's just an enum, so perhaps ReplicaSelectionMode would be a clearer name? -- To view, visit http://gerrit.cloudera.org:8080/8161 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I303a6d158184575a9a105c2d2bf26961ae8b3e93 Gerrit-Change-Number: 8161 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 02 Oct 2017 21:36:53 +0000 Gerrit-HasComments: Yes
