Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8161 )
Change subject: [catalog manager] introduce replica type matching policy ...................................................................... Patch Set 7: (7 comments) overall lgtm http://gerrit.cloudera.org:8080/#/c/8161/7/src/kudu/master/catalog_manager.h File src/kudu/master/catalog_manager.h: http://gerrit.cloudera.org:8080/#/c/8161/7/src/kudu/master/catalog_manager.h@722 PS7, Line 722: include_non_voters flag name changed http://gerrit.cloudera.org:8080/#/c/8161/7/src/kudu/master/catalog_manager.h@723 PS7, Line 723: inconsistency unclear to me what this means http://gerrit.cloudera.org:8080/#/c/8161/7/src/kudu/master/catalog_manager.h@727 PS7, Line 727: sel how about naming this 'filter' ? http://gerrit.cloudera.org:8080/#/c/8161/7/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/8161/7/src/kudu/master/master.proto@366 PS7, Line 366: ReplicaMatchPolicy How about ReplicaTypeFilter http://gerrit.cloudera.org:8080/#/c/8161/7/src/kudu/master/master.proto@378 PS7, Line 378: match_policy replica_type_filter ? http://gerrit.cloudera.org:8080/#/c/8161/7/src/kudu/master/master.proto@463 PS7, Line 463: match_policy same http://gerrit.cloudera.org:8080/#/c/8161/7/src/kudu/master/master_service.cc File src/kudu/master/master_service.cc: http://gerrit.cloudera.org:8080/#/c/8161/7/src/kudu/master/master_service.cc@241 PS7, Line 241: unknown todd (per https://github.com/apache/kudu/blame/master/src/kudu/master/master_service.cc#L241 ) -- To view, visit http://gerrit.cloudera.org:8080/8161 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I303a6d158184575a9a105c2d2bf26961ae8b3e93 Gerrit-Change-Number: 8161 Gerrit-PatchSet: 7 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 29 Nov 2017 03:15:22 +0000 Gerrit-HasComments: Yes
