Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8208
to look at the new patch set (#2).
Change subject: itest: allow use of verifiers with EMCs that specify
non-default block managers
......................................................................
itest: allow use of verifiers with EMCs that specify non-default block managers
ClusterVerifier and LogVerifier both rely on opening a new FsManager,
using the current FLAG_block_manager of the caller process.
ExternalMiniClusters, on the other hand, grant the flexibility to
specify any flags, and create the cluster in a separate process.
This precluded the Verifiers from operating on ExternalMiniClusters that
are specified with different block manager types than that of the
Verifier's caller.
To remediate this, block manager type has been added as an option to
start up an ExternalMiniCluster (i.e. both ExternalMasters and
ExternalTabletServers will now store their block manager type). This
option is also taken into account by the Verifiers.
To test, I parameterized disk_failure-itest, which exercises using a
ClusterVerifier and LogVerifier, and restarts an ExternalTabletServer.
Change-Id: Iaa44eb33d0c025830f97a2ed7583c8186f915e94
---
M src/kudu/integration-tests/disk_failure-itest.cc
M src/kudu/integration-tests/external_mini_cluster-itest-base.cc
M src/kudu/integration-tests/external_mini_cluster-itest-base.h
M src/kudu/integration-tests/log_verifier.cc
M src/kudu/integration-tests/log_verifier.h
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
7 files changed, 62 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/8208/2
--
To view, visit http://gerrit.cloudera.org:8080/8208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaa44eb33d0c025830f97a2ed7583c8186f915e94
Gerrit-Change-Number: 8208
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
