Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8208 )
Change subject: itest: allow use of verifiers with EMCs that specify non-default block managers ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/8208/5/src/kudu/mini-cluster/external_mini_cluster.h File src/kudu/mini-cluster/external_mini_cluster.h: http://gerrit.cloudera.org:8080/#/c/8208/5/src/kudu/mini-cluster/external_mini_cluster.h@75 PS5, Line 75: struct ExternalMiniClusterOptions { You may have a conflict here when you rebase; I reformatted some of these comments. http://gerrit.cloudera.org:8080/#/c/8208/5/src/kudu/mini-cluster/external_mini_cluster.h@332 PS5, Line 332: std::string daemon_bin_path_; Can this also be eliminated? -- To view, visit http://gerrit.cloudera.org:8080/8208 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaa44eb33d0c025830f97a2ed7583c8186f915e94 Gerrit-Change-Number: 8208 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Fri, 06 Oct 2017 17:25:16 +0000 Gerrit-HasComments: Yes
