Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/7853 )
Change subject: tool: new action for running mini-clusters ...................................................................... Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/7853/8/src/kudu/tools/tool.proto File src/kudu/tools/tool.proto: http://gerrit.cloudera.org:8080/#/c/7853/8/src/kudu/tools/tool.proto@28 PS8, Line 28: // If not provided, the defaults from that class will be used instead. > > Once you've gone that far, it's trivial to convert that optional<External Fine. I still think there's room for this in the future (e.g. disaster recovery where there may be two clusters that need to be aware of one another), but I suppose it'll be relatively easy to add then. http://gerrit.cloudera.org:8080/#/c/7853/8/src/kudu/tools/tool.proto@29 PS8, Line 29: // > required fields should never be added to protobuf messages. This isn't spe It's a moot point now that I've removed multi-cluster functionality, though I did make the process_id in Start/StopProcessRequestPB optional since you feel strongly about this. http://gerrit.cloudera.org:8080/#/c/7853/8/src/kudu/tools/tool.proto@97 PS8, Line 97: } > Would this API be used for HMS/Sentry processes if/when those are added to Yeah. As we discussed, I changed this to use ID-based addressing, where the IDs are "master0", "tserver1", "kdc", etc. That also means you can stop a KDC through it now. -- To view, visit http://gerrit.cloudera.org:8080/7853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0e693921ef780dc4a06e536c6b7408f7f0b252f6 Gerrit-Change-Number: 7853 Gerrit-PatchSet: 10 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Wed, 04 Oct 2017 23:22:17 +0000 Gerrit-HasComments: Yes
