Dan Burkert has posted comments on this change. (
http://gerrit.cloudera.org:8080/7853 )
Change subject: tool: new action for running mini-clusters
......................................................................
Patch Set 12:
(1 comment)
I think I have some additional feedback on the proto API, but I wanted to run
this myself to get some experience before suggesting changes. I ran into a
linker error on macos, perhaps we can debug when we're in the office together:
Undefined symbols for architecture x86_64:
"kudu::HostPortPB::MergePartialFromCodedStream(google::protobuf::io::CodedInputStream*)",
referenced from:
bool
google::protobuf::internal::WireFormatLite::ReadMessageNoVirtual<kudu::HostPortPB>(google::protobuf::io::CodedInputStream*,
kudu::HostPortPB*) in tool.pb.cc.o
"kudu::HostPortPB::Clear()", referenced from:
kudu::tools::DaemonInfoPB::Clear() in tool.pb.cc.o
"kudu::HostPortPB::MergeFrom(kudu::HostPortPB const&)", referenced from:
kudu::tools::DaemonInfoPB::MergeFrom(kudu::tools::DaemonInfoPB const&) in
tool.pb.cc.o
"kudu::HostPortPB::HostPortPB(kudu::HostPortPB const&)", referenced from:
kudu::tools::DaemonInfoPB::DaemonInfoPB(kudu::tools::DaemonInfoPB const&)
in tool.pb.cc.o
"kudu::HostPortPB::HostPortPB()", referenced from:
kudu::tools::DaemonInfoPB::mutable_bound_rpc_address() in tool.pb.cc.o
"kudu::AppStatusPB::MergePartialFromCodedStream(google::protobuf::io::CodedInputStream*)",
referenced from:
bool
google::protobuf::internal::WireFormatLite::ReadMessageNoVirtual<kudu::AppStatusPB>(google::protobuf::io::CodedInputStream*,
kudu::AppStatusPB*) in tool.pb.cc.o
"kudu::AppStatusPB::Clear()", referenced from:
kudu::tools::ControlShellResponsePB::Clear() in tool.pb.cc.o
"kudu::AppStatusPB::MergeFrom(kudu::AppStatusPB const&)", referenced from:
kudu::tools::ControlShellResponsePB::MergeFrom(kudu::tools::ControlShellResponsePB
const&) in tool.pb.cc.o
"kudu::AppStatusPB::AppStatusPB(kudu::AppStatusPB const&)", referenced from:
kudu::tools::ControlShellResponsePB::ControlShellResponsePB(kudu::tools::ControlShellResponsePB
const&) in tool.pb.cc.o
"kudu::AppStatusPB::AppStatusPB()", referenced from:
kudu::tools::ControlShellResponsePB::mutable_error() in tool.pb.cc.o
"kudu::_HostPortPB_default_instance_", referenced from:
kudu::HostPortPB::internal_default_instance() in tool.pb.cc.o
kudu::tools::DaemonInfoPB::bound_rpc_address() const in tool.pb.cc.o
"kudu::_AppStatusPB_default_instance_", referenced from:
kudu::AppStatusPB::internal_default_instance() in tool.pb.cc.o
kudu::tools::ControlShellResponsePB::error() const in tool.pb.cc.o
"kudu::protobuf_kudu_2fcommon_2fcommon_2eproto::InitDefaults()", referenced
from:
kudu::tools::protobuf_kudu_2ftools_2ftool_2eproto::TableStruct::InitDefaultsImpl()
in tool.pb.cc.o
"kudu::protobuf_kudu_2fcommon_2fcommon_2eproto::AddDescriptors()", referenced
from:
kudu::tools::protobuf_kudu_2ftools_2ftool_2eproto::(anonymous
namespace)::AddDescriptorsImpl() in tool.pb.cc.o
"kudu::protobuf_kudu_2fcommon_2fwire_5fprotocol_2eproto::InitDefaults()",
referenced from:
kudu::tools::protobuf_kudu_2ftools_2ftool_2eproto::TableStruct::InitDefaultsImpl()
in tool.pb.cc.o
"kudu::protobuf_kudu_2fcommon_2fwire_5fprotocol_2eproto::AddDescriptors()",
referenced from:
kudu::tools::protobuf_kudu_2ftools_2ftool_2eproto::(anonymous
namespace)::AddDescriptorsImpl() in tool.pb.cc.o
"kudu::HostPortPB::ByteSizeLong() const", referenced from:
unsigned long
google::protobuf::internal::WireFormatLite::MessageSizeNoVirtual<kudu::HostPortPB>(kudu::HostPortPB
const&) in tool.pb.cc.o
"kudu::HostPortPB::IsInitialized() const", referenced from:
kudu::tools::DaemonInfoPB::IsInitialized() const in tool.pb.cc.o
"kudu::HostPortPB::InternalSerializeWithCachedSizesToArray(bool, unsigned
char*) const", referenced from:
unsigned char*
google::protobuf::internal::WireFormatLite::InternalWriteMessageNoVirtualToArray<kudu::HostPortPB>(int,
kudu::HostPortPB const&, bool, unsigned char*) in tool.pb.cc.o
"kudu::AppStatusPB::ByteSizeLong() const", referenced from:
unsigned long
google::protobuf::internal::WireFormatLite::MessageSizeNoVirtual<kudu::AppStatusPB>(kudu::AppStatusPB
const&) in tool.pb.cc.o
"kudu::AppStatusPB::IsInitialized() const", referenced from:
kudu::tools::ControlShellResponsePB::IsInitialized() const in tool.pb.cc.o
"kudu::AppStatusPB::InternalSerializeWithCachedSizesToArray(bool, unsigned
char*) const", referenced from:
unsigned char*
google::protobuf::internal::WireFormatLite::InternalWriteMessageNoVirtualToArray<kudu::AppStatusPB>(int,
kudu::AppStatusPB const&, bool, unsigned char*) in tool.pb.cc.o
http://gerrit.cloudera.org:8080/#/c/7853/12/src/kudu/tools/tool.proto
File src/kudu/tools/tool.proto:
http://gerrit.cloudera.org:8080/#/c/7853/12/src/kudu/tools/tool.proto@68
PS12, Line 68: UNKNOWN_DAEMON = 999;
Use 0 for unknown and count up from there. This is a best-practice, and is
enforced as of proto3. We have other UNKNOWN=999; instances in the codebase
because we retroactively added it after already having a 0 value.
--
To view, visit http://gerrit.cloudera.org:8080/7853
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e693921ef780dc4a06e536c6b7408f7f0b252f6
Gerrit-Change-Number: 7853
Gerrit-PatchSet: 12
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Comment-Date: Fri, 06 Oct 2017 18:14:02 +0000
Gerrit-HasComments: Yes
