Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8141 )
Change subject: [webui] Allow custom response codes and headers ...................................................................... [webui] Allow custom response codes and headers Previously, the path handlers used to implement pages in the web ui could only return 200 OK and could not set any headers, as these two aspects of the HTTP response were handled in the underlying webserver code. This patch introduces WebResponse and PrerenderedWebResponse structs that wrap and replace the 'output' EasyJson and ostringstream pointers, respectively, used before, and which have fields for the response code and additional headers. The ability to add headers isn't currently used, but it's nice to have. The response codes are adjusted where necessary to match what one would expect, e.g. navigating to /tablet?id=foo returns 404. Change-Id: I9ff890785eeb2df3eed9e7c54d0daf760c8b3924 Reviewed-on: http://gerrit.cloudera.org:8080/8141 Reviewed-by: Adar Dembo <[email protected]> Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon <[email protected]> --- M src/kudu/master/master-path-handlers.cc M src/kudu/master/master-path-handlers.h M src/kudu/server/default-path-handlers.cc M src/kudu/server/pprof-path-handlers.cc M src/kudu/server/rpcz-path-handler.cc M src/kudu/server/tracing-path-handlers.cc M src/kudu/server/webserver.cc M src/kudu/server/webserver.h M src/kudu/tserver/tserver-path-handlers.cc M src/kudu/tserver/tserver-path-handlers.h M src/kudu/util/thread.cc M src/kudu/util/web_callback_registry.h 12 files changed, 269 insertions(+), 137 deletions(-) Approvals: Adar Dembo: Looks good to me, but someone else must approve Kudu Jenkins: Verified Todd Lipcon: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/8141 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I9ff890785eeb2df3eed9e7c54d0daf760c8b3924 Gerrit-Change-Number: 8141 Gerrit-PatchSet: 13 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]>
