Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8141 )
Change subject: [webui] Allow custom response codes and headers ...................................................................... Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/8141/6/src/kudu/server/webserver.h File src/kudu/server/webserver.h: http://gerrit.cloudera.org:8080/#/c/8141/6/src/kudu/server/webserver.h@66 PS6, Line 66: // Register a route 'path' to be rendered via template. > What about 'alias'? Done http://gerrit.cloudera.org:8080/#/c/8141/6/src/kudu/server/webserver.cc File src/kudu/server/webserver.cc: http://gerrit.cloudera.org:8080/#/c/8141/6/src/kudu/server/webserver.cc@452 PS6, Line 452: HttpResponseHeaders{} > Done Actually seems it doesn't work in general (though it did on macos) -- see TidyBot's comment on PS7 http://gerrit.cloudera.org:8080/#/c/8141/8/src/kudu/server/webserver.cc File src/kudu/server/webserver.cc: http://gerrit.cloudera.org:8080/#/c/8141/8/src/kudu/server/webserver.cc@472 PS8, Line 472: headers_stream << "\r\n"; > Can use unordered_set which is hash based and slightly faster on average. Done http://gerrit.cloudera.org:8080/#/c/8141/8/src/kudu/server/webserver.cc@475 PS8, Line 475: // Make sure to use sq_write for printing the body; sq_printf truncates at 8KB. > Hmm, this seems too quiet: if a callback tries to send an invalid header, i Done -- To view, visit http://gerrit.cloudera.org:8080/8141 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ff890785eeb2df3eed9e7c54d0daf760c8b3924 Gerrit-Change-Number: 8141 Gerrit-PatchSet: 6 Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Wed, 04 Oct 2017 09:08:38 +0000 Gerrit-HasComments: Yes
