Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/7887 )
Change subject: WIP [raft_consensus-itest] fix flake in TestSlowLeader ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7887/2/src/kudu/integration-tests/test_workload.cc File src/kudu/integration-tests/test_workload.cc: http://gerrit.cloudera.org:8080/#/c/7887/2/src/kudu/integration-tests/test_workload.cc@220 PS2, Line 220: while (true) { instead what if we just used READ_AT_SNAPSHOT scan mode and propagated timestamps back from the writer threads? that way we'd actually get coverage of our snapshot scan code paths. -- To view, visit http://gerrit.cloudera.org:8080/7887 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie5ee6c5400c947f87b1da2e76d24dd837b1270ca Gerrit-Change-Number: 7887 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Fri, 06 Oct 2017 01:29:24 +0000 Gerrit-HasComments: Yes
