Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8228 )
Change subject: Implement per-tablet scanner metrics ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8228/1/src/kudu/tserver/scanners.cc File src/kudu/tserver/scanners.cc: http://gerrit.cloudera.org:8080/#/c/8228/1/src/kudu/tserver/scanners.cc@34 PS1, Line 34: #include "kudu/tserver/scanner_metrics.h" > warning: #includes are not sorted properly [llvm-include-order] Done http://gerrit.cloudera.org:8080/#/c/8228/1/src/kudu/tserver/tablet_server-test.cc File src/kudu/tserver/tablet_server-test.cc: http://gerrit.cloudera.org:8080/#/c/8228/1/src/kudu/tserver/tablet_server-test.cc@131 PS1, Line 131: METRIC_DECLARE_entity(tablet); > warning: redundant 'METRIC_ENTITY_tablet' declaration [readability-redundan Done -- To view, visit http://gerrit.cloudera.org:8080/8228 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b2d85f78c655e02654f8581e9521452b149b7d5 Gerrit-Change-Number: 8228 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 06 Oct 2017 21:20:42 +0000 Gerrit-HasComments: Yes
