Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8228 )
Change subject: Implement per-tablet active scanner metric ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8228/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8228/2//COMMIT_MSG@11 PS2, Line 11: - scanners_expired : - scanner_duration > have you found these two metrics to be useful in practice? Nope. I was establishing parity with the server-level metrics. > It seems on larger clusters we're starting to hit some scalability limits > with per-tablet metric collection I'm curious to know what the limits were. > if we don't have good use cases for these, maybe we should leave them as is? OK. I'll leave them out. I kept the new test for expired scanners (minus the per-tablet part) since it adds coverage. -- To view, visit http://gerrit.cloudera.org:8080/8228 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b2d85f78c655e02654f8581e9521452b149b7d5 Gerrit-Change-Number: 8228 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 16 Oct 2017 06:34:42 +0000 Gerrit-HasComments: Yes
