Hello Dan Burkert, Wes McKinney, Jordan Birdsell,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/8236
to review the following change.
Change subject: python: replace bespoke minicluster implementation with control
shell
......................................................................
python: replace bespoke minicluster implementation with control shell
In this case we're using JSON serialization to talk to the shell because the
Python bindings don't already make use of protobuf.
I had to update test_scantoken.py to shut down its multiprocessing pool
after using it, otherwise its subprocesses inherited a copy of the control
shell stdin pipe writer. This led to hangs on stop_cluster() because closing
the control shell's stdin didn't actually close the last stdin writer, thus
the control shell didn't exit.
Change-Id: I821e864cfe738a4d39ae039b95ca38f16cdcfb82
---
M python/kudu/tests/common.py
M python/kudu/tests/test_scantoken.py
2 files changed, 39 insertions(+), 96 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/36/8236/1
--
To view, visit http://gerrit.cloudera.org:8080/8236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I821e864cfe738a4d39ae039b95ca38f16cdcfb82
Gerrit-Change-Number: 8236
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Jordan Birdsell <[email protected]>
Gerrit-Reviewer: Wes McKinney <[email protected]>
