Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8236 )
Change subject: python: replace bespoke minicluster implementation with control shell ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8236/2/python/kudu/tests/common.py File python/kudu/tests/common.py: http://gerrit.cloudera.org:8080/#/c/8236/2/python/kudu/tests/common.py@50 PS2, Line 50: if "error" in response: > For my own edification, is this doing a string match, or is it actually che This is after the call to json.loads() so 'response' is a Python dict type, and we're checking for the "error" key in it. -- To view, visit http://gerrit.cloudera.org:8080/8236 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I821e864cfe738a4d39ae039b95ca38f16cdcfb82 Gerrit-Change-Number: 8236 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jordan Birdsell <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Wes McKinney <[email protected]> Gerrit-Comment-Date: Mon, 09 Oct 2017 23:51:38 +0000 Gerrit-HasComments: Yes
